Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punycode deprecated #191

Open
ataggdev opened this issue Jun 10, 2024 · 1 comment
Open

punycode deprecated #191

ataggdev opened this issue Jun 10, 2024 · 1 comment

Comments

@ataggdev
Copy link

Had everything working for about a week. Then noticed that it stopped displaying photos, started digging and found that my token expired a couple days ago even though I did everything within the instructions to avoid that.

I started the process to renew the token and found when trying to run the "node generate_token_v2.js" I was getting

"(node:163930) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead."

Found similar problem here, https://stackoverflow.com/questions/68774489/punycode-is-deprecated-in-npm-what-should-i-replace-it-with

I went in and found that the below files would need the "require("punycode");" changed to "require('punycode/');".

MagicMirror/modules/MMM-GooglePhotos/node_modules/whatwg-url/lib/url-state-machine.js
MagicMirror/modules/MMM-GooglePhotos/node_modules/tr46/index.js

After the change I was able to complete the generation process. I am hoping it won't break again after a week, I do have it set to in production within the Google API pages.

@hermanho
Copy link
Owner

related to googleapis/gaxios#508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants