Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires OS X 10.7 #5

Closed
crazydevman opened this issue Sep 22, 2011 · 7 comments
Closed

Requires OS X 10.7 #5

crazydevman opened this issue Sep 22, 2011 · 7 comments

Comments

@crazydevman
Copy link

I just downloaded the latest version (1.0.6) and I get this error message when trying to open it up:

"You have Mac OS X 10.6.8. The application requires Mac OS X 10.7 or later."

On your website it says this works for 10.5+, is this no longer the case?

@alexcrichton
Copy link
Contributor

Sorry I've been meaning to update that site for awhile to say 10.7+ (it now says that). I use xcode 10.7 to build hermes, and I don't know of a way to build for a lower version of OSX.

There are previous versions which work with 10.6, but sadly Pandora has updated it's API version since then. Until I find a way to compile for versions lower than 10.7, I won't be able to release version compatible with 10.6/10.5

@tresni
Copy link
Contributor

tresni commented Nov 14, 2011

From 915352b3a02cb5baf4d576da387d0275b72232f7 Mon Sep 17 00:00:00 2001
From: Brian Hartvigsen <brian.andrew@brianandjenny.com>
Date: Sat, 12 Nov 2011 16:57:09 -0700
Subject: [PATCH] Making hermes 10.6 compatible

---
 Classes/HermesAppDelegate.m      |    2 --
 Hermes.xcodeproj/project.pbxproj |    4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/Classes/HermesAppDelegate.m b/Classes/HermesAppDelegate.m
index 7a8037f..ca8c9a8 100644
--- a/Classes/HermesAppDelegate.m
+++ b/Classes/HermesAppDelegate.m
@@ -72,8 +72,6 @@
 }

 - (void)applicationDidFinishLaunching:(NSNotification *)aNotification {
-  [window setRestorable:YES];
-  [window setRestorationClass:[self class]];

   [[NSNotificationCenter defaultCenter]
     addObserver:self
diff --git a/Hermes.xcodeproj/project.pbxproj b/Hermes.xcodeproj/project.pbxproj
index 35e0e68..2a8fe04 100644
--- a/Hermes.xcodeproj/project.pbxproj
+++ b/Hermes.xcodeproj/project.pbxproj
@@ -543,7 +543,7 @@
                GCC_WARN_PEDANTIC = NO;
                INFOPLIST_FILE = "Resources/Hermes-Info.plist";
                INSTALL_PATH = "$(HOME)/Applications";
-               MACOSX_DEPLOYMENT_TARGET = 10.7;
+               MACOSX_DEPLOYMENT_TARGET = 10.6;
                OTHER_CFLAGS = "-DDEBUG";
                PRODUCT_NAME = Hermes;
                SDKROOT = macosx;
@@ -566,7 +566,7 @@
                GCC_WARN_PEDANTIC = NO;
                INFOPLIST_FILE = "Resources/Hermes-Info.plist";
                INSTALL_PATH = "$(HOME)/Applications";
-               MACOSX_DEPLOYMENT_TARGET = 10.7;
+               MACOSX_DEPLOYMENT_TARGET = 10.6;
                PRODUCT_NAME = Hermes;
                SDKROOT = macosx;
            };
-- 
1.7.3.3

@alexcrichton
Copy link
Contributor

The problem with this is that I'm still not sure how to compile Hermes for 10.6. It's certainly possible to just not use 10.7 APIs, but the resulting binary isn't compatible with 10.6. Do you know if this patch fixes this? Does a binary compiled with recent xcode run on 10.6 by just changing the deployment target? If it does, by all means I'll pull this in :)

@tresni
Copy link
Contributor

tresni commented Nov 14, 2011

I'm using XCode 4.0 to compile and run a binary on 10.6. That is the only difference between your code and what it took for me to make it run on 10.6.

While I have a machine running 10.7, it does not have XCode installed (and I'm currently remote) so I can't test. What I've been told is that if you are compiling using the 10.7 SDK then you don't have to remove the 10.7 specific APIs, simply change the MacOS Target and everything will auto compensate.

@alexcrichton alexcrichton reopened this Nov 15, 2011
@alexcrichton
Copy link
Contributor

Does this build work for you on 10.6?

@tresni
Copy link
Contributor

tresni commented Nov 15, 2011

Works for me on 10.6.8, Image Proof

@alexcrichton
Copy link
Contributor

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants