Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feedback about transaction status #198

Open
druiz0992 opened this issue Apr 16, 2021 · 8 comments
Open

Provide feedback about transaction status #198

druiz0992 opened this issue Apr 16, 2021 · 8 comments
Assignees
Labels
type: feature request Request for adding a new feature

Comments

@druiz0992
Copy link
Contributor

APi provides some information of transaction cannot be processed. This info should appear also in explorer

@druiz0992 druiz0992 added the type: feature request Request for adding a new feature label Apr 16, 2021
@mmilenkovic
Copy link
Collaborator

@rafal-na @chamian Please advise on this request.

@chamian
Copy link

chamian commented May 6, 2021

@druiz0992 what are the type of errors that the API provides regarding invalid transactions?

@druiz0992
Copy link
Contributor Author

druiz0992 commented May 11, 2021

There errors are something like insufficient balance or unexpected nonce. There may be others. Do you need a complete list of the errors?

@mmilenkovic
Copy link
Collaborator

@druiz0992 I think it would be worth it, so that Chami can take all of them into account.

@druiz0992
Copy link
Contributor Author

druiz0992 commented May 11, 2021

  • Tx not selected due impossibility to be forged with the current state : Not sure what this means
  • Tx not selected due to not enough Balance at the sender
  • Tx not selected due to not current Nonce

@chamian
Copy link

chamian commented May 11, 2021

Thanks @druiz0992 . Could you provide more details about these errors?

(bullet) 1. Is this error related with the network malfunctioning or being stopped?

(bullet) 2. As we try to prevent errors, we don't let the user continue with a tx if he doesn't have funds or enough eth for gas fees. Is this error appearing in case a transaction is about to be forged and the user has spent his eths not being able to cover gas fees? Are there other cases when this error could appear beside this one?

(bullet) 3. I don't understand this error. What does not current Nonce mean?

@druiz0992
Copy link
Contributor Author

druiz0992 commented May 12, 2021

@chamian : What i would like to accomplish is that when the explorer displays a transaction as Pending, it gives a motive so that it can be corrected.
One of the motives (2) is that there is not enough balance. The node detects that and doesn't allow the transaction to be forged, and it's flagged as pending indefinitely. I would like that if this is the case, there is a message in the explorer showing why the transaction is pending.
Motive (3) is copied verbatim from the node. I needs to be reworded, but it means that the transaction's nonce is not as expected, and this transaction thus will be pending until resolved.
Motive (1) is really obscure to me. I will try to find out more.

@mmilenkovic
Copy link
Collaborator

Motive (2) can be implemented, check transaciton pool response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request Request for adding a new feature
Projects
None yet
Development

No branches or pull requests

4 participants