Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diverging state of master and devel branches #10

Closed
jschwe opened this issue May 6, 2020 · 3 comments
Closed

diverging state of master and devel branches #10

jschwe opened this issue May 6, 2020 · 3 comments

Comments

@jschwe
Copy link
Contributor

jschwe commented May 6, 2020

I am somewhat confused why master and devel branch have diverged so much. As someone new to the codebase I can't even be sure to what exactly the differences are.

From what I've seen the master branch takes hermit-sys from crates.io, and this makes it hard to keep devel and master in sync. What are the benefits in downloading hermit-sys from crates.io versus using hermit-sys with the lib-hermit submodule at a fixed commit?

@stlankes
Copy link
Contributor

stlankes commented May 15, 2020

Hm, it is confusing. For external user is the crates.io version easier to use. They have not to add libhermit as submodule. In addition, if they use libhermit as submodule, they are not able to publish an application at crates.io.

@jschwe
Copy link
Contributor Author

jschwe commented May 18, 2020

I think it might be better to point an external user to a specific repository that provides a demo app using crates.io. That's basically what https://github.com/hermitcore/rusty-demo/ was meant for, wasn't it?
Regarding your second point, isn't Multiple locations for dependencies a solution for that problem?
Edit: Since I'm also a bit confused about the relations of the names between git repos and crates, Renaming dependencies might also be needed.

@stlankes
Copy link
Contributor

stlankes commented Jun 4, 2020

Today, the branch devel isn't longer used. See #28

@stlankes stlankes closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants