Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing git lfs #84

Closed
jschwe opened this issue Dec 3, 2020 · 4 comments
Closed

Consider removing git lfs #84

jschwe opened this issue Dec 3, 2020 · 4 comments

Comments

@jschwe
Copy link
Contributor

jschwe commented Dec 3, 2020 •
edited

git LFS is an additional dependancy that needs to be installed. Considering that the gif was removed and the remaining image stored using LFS is only 10 KB in size, we should consider removing LFS.

On windows using powershell cloning a repo with LFS fails, apparently due to a bug in (windows) openssh.
@stlankes
Copy link
Contributor

stlankes commented Dec 3, 2020

It is a pain to work with Windows :-)

@stlankes
Copy link
Contributor

stlankes commented Dec 3, 2020

libhermit-rs is maybe a problem. Their is one image, which is 12 MB large.

@jbreitbart
Copy link
Contributor

And uhyve uses LFS to store benches_data/hello_world

@jschwe
Copy link
Contributor Author

jschwe commented Dec 4, 2020

Ah okay, I wasn't aware of that. Removing LFS doesn't make too much sense then.

@jschwe jschwe closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbreitbart @stlankes @jschwe