Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of internal syscalls #715

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Replace use of internal syscalls #715

merged 1 commit into from
Apr 20, 2023

Conversation

nathanwhyte
Copy link
Contributor

@nathanwhyte nathanwhyte commented Apr 20, 2023

Closes #676

I found no internal uses of __sys_realloc() or __sys_free() anywhere.

I did find one reference to __sys_shutdown():
https://github.com/hermitcore/libhermit-rs/blob/df7483de1b762c570f5d52e48fc396cdb739a12d/src/arch/x86_64/kernel/processor.rs#L832-L836

It doesn't redirect to any functions in lib.rs like __sys_malloc() does. Does it need to be replaced as well?

@mkroening mkroening self-requested a review April 20, 2023 17:18
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me 👍

bors r+

Regarding shutdown: I opened #718 to track that.
I also opened #717 for moving the sys_alloc functions as a follow-up.

@bors
Copy link
Contributor

bors bot commented Apr 20, 2023

Build succeeded:

@bors bors bot merged commit c0ed73e into hermit-os:master Apr 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use syscalls internally
2 participants