Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic docs for timer and semaphore syscalls #719

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Add basic docs for timer and semaphore syscalls #719

merged 4 commits into from
Apr 25, 2023

Conversation

nathanwhyte
Copy link
Contributor

Helping with issue #353

Added (very) basic documentation to syscalls in timer.rs and semaphore.rs

I used Linux man pages as a reference when writing these.

@mkroening mkroening self-requested a review April 24, 2023 05:08
@mkroening mkroening self-assigned this Apr 24, 2023
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. :)

Generally, this looks good. I would like these docs to be a bit more rusty, though. Specifically, an items documentation should start with a short sentence, then have an empty line, and then go into details. The details should also be relevant for API usage and not be implementation details. Comments about implementation details are welcome as well, but should be marked as documentation. Implementation details often fit better inside the function to where stuff happens, but might also be fit for placement outside the function.

Made-up example:

/// Yields to the executor.
///
/// This function can be used for ...
// We save the task handle in ... and reschedule.
extern "C" fn sys_yield () {

For more information see:

PS: Remember punctuation at the end of sentences in the doc comments.

@stlankes stlankes self-requested a review April 25, 2023 12:32
@stlankes
Copy link
Contributor

bors r+

@stlankes
Copy link
Contributor

@nathanwhyte Thanks for the support!

@bors
Copy link
Contributor

bors bot commented Apr 25, 2023

@bors bors bot merged commit 30acc1c into hermit-os:master Apr 25, 2023
9 checks passed
@nathanwhyte
Copy link
Contributor Author

Thank you to everyone for being accommodating while I was working on these issues. Y'all saved me from a bad project grade by helping me solve them! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants