-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic docs for timer and semaphore syscalls #719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. :)
Generally, this looks good. I would like these docs to be a bit more rusty, though. Specifically, an items documentation should start with a short sentence, then have an empty line, and then go into details. The details should also be relevant for API usage and not be implementation details. Comments about implementation details are welcome as well, but should be marked as documentation. Implementation details often fit better inside the function to where stuff happens, but might also be fit for placement outside the function.
Made-up example:
/// Yields to the executor.
///
/// This function can be used for ...
// We save the task handle in ... and reschedule.
extern "C" fn sys_yield () {
For more information see:
- https://doc.rust-lang.org/rustdoc/how-to-write-documentation.html
- https://rust-lang.github.io/api-guidelines/documentation.html
- The standard library documentation as example.
PS: Remember punctuation at the end of sentences in the doc comments.
bors r+ |
@nathanwhyte Thanks for the support! |
Thank you to everyone for being accommodating while I was working on these issues. Y'all saved me from a bad project grade by helping me solve them! 😆 |
Helping with issue #353
Added (very) basic documentation to syscalls in
timer.rs
andsemaphore.rs
I used Linux man pages as a reference when writing these.