Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't initialize IO-APIC for uhyve #725

Merged
merged 1 commit into from
Apr 27, 2023
Merged

don't initialize IO-APIC for uhyve #725

merged 1 commit into from
Apr 27, 2023

Conversation

stlankes
Copy link
Contributor

uhyve doesn't support a common IO-APIC. Consequently, libhermit should not initialize the IO-APIC

@stlankes stlankes changed the title don't initialize for uhyve don't initialize IO-APIC for uhyve Apr 27, 2023
@stlankes
don't initialize IO-APIC for uhyve
32510fd 
uhyve doesn't support a common IO-APIC. Consequently, libhermit
should not initialize the IO-APIC
@jounathaen
Copy link
Member

LGTM!

@jounathaen
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 27, 2023

Build succeeded:

@bors bors bot merged commit 5637470 into hermit-os:master Apr 27, 2023
9 checks passed
@stlankes stlankes mentioned this pull request Apr 27, 2023
Merged
bors bot added a commit that referenced this pull request Apr 27, 2023
@bors @stlankes
Merge #726
378fbd8 
726: remove obsolete function `detect_from_uhyve` r=jounathaen a=stlankes

- minor improvements to #725
- removing obsolete code

Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jounathaen jounathaen Awaiting requested review from jounathaen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stlankes @jounathaen