Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clippy warnings, adhere Rust 2018 idioms #118

Merged
merged 28 commits into from
Jun 28, 2021
Merged

Fix Clippy warnings, adhere Rust 2018 idioms #118

merged 28 commits into from
Jun 28, 2021

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Jun 13, 2021 •
edited

Includes and supersedes #117.

@mkroening mkroening requested a review from stlankes June 13, 2021 17:12
@mkroening mkroening self-assigned this Jun 13, 2021
@codecov
Copy link

codecov bot commented Jun 13, 2021 •
edited

Codecov Report

Merging #118 (d5ab2aa) into master (4e206d3) will increase coverage by 0.04%.
The diff coverage is 5.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   19.82%   19.87%   +0.04%     
==========================================
  Files          21       21              
  Lines        5190     5168      -22     
==========================================
- Hits         1029     1027       -2     
+ Misses       4161     4141      -20
Impacted Files Coverage Δ
src/arch/x86.rs 77.77% <ø> (ø)
src/error.rs 2.85% <0.00%> (ø)
src/linux/gdb.rs 0.00% <0.00%> (ø)
src/linux/uhyve.rs 0.00% <0.00%> (ø)
src/linux/vcpu.rs 0.00% <ø> (ø)
src/linux/virtio.rs 0.00% <0.00%> (ø)
src/linux/virtqueue.rs 0.00% <0.00%> (ø)
src/macos/gdb.rs 0.00% <0.00%> (ø)
src/macos/ioapic.rs 0.00% <0.00%> (ø)
src/macos/uhyve.rs 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e206d3...d5ab2aa. Read the comment docs.

jounathaen
jounathaen reviewed Jun 14, 2021
View reviewed changes
src/macos/gdb.rs Outdated Show resolved Hide resolved
jounathaen
jounathaen approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@jounathaen jounathaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank's for your effort!

@mkroening mkroening mentioned this pull request Jun 14, 2021
Closed
@mkroening
Copy link
Member Author

Fixed formatting of the last commit.

@mkroening mkroening changed the title Adapt Rust 2018 idioms Fix Clippy warnings, adhere Rust 2018 idioms Jun 14, 2021
@mkroening
Copy link
Member Author

Rebased on latest master.

@jounathaen
Copy link
Member

I guess, in this case you could stash the commits together...

@mkroening
Copy link
Member Author

I guess, in this case you could stash the commits together...

I liked the idea of fixing one clippy lint at a time, having the commit message explain, which lint was triggered.

But if you want me to, I can squash the first 31 commits.

@stlankes
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request Jun 14, 2021
@bors @mkroening
Merge #118
95e7b95 
118: Fix Clippy warnings, adhere Rust 2018 idioms r=stlankes a=mkroening

Includes and supersedes  #117.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
@stlankes
Copy link
Collaborator

@mkroening 👍

@bors
Copy link
Contributor

bors bot commented Jun 14, 2021

Build failed:

@mkroening
Copy link
Member Author

I addressed @jounathaen's concern and squashed three commits where I was fixing the same lint for different targets (Linux/macOS).

@jounathaen
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jun 15, 2021
@bors @mkroening
Merge #118
bdd019d 
118: Fix Clippy warnings, adhere Rust 2018 idioms r=jounathaen a=mkroening

Includes and supersedes  #117.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
@bors
Copy link
Contributor

bors bot commented Jun 15, 2021

Build failed:

@mkroening
Copy link
Member Author

Rebased on latest master.

@jounathaen
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 28, 2021

Build succeeded:

@bors bors bot merged commit 4e51084 into hermit-os:master Jun 28, 2021
@mkroening mkroening deleted the more-clippy branch July 14, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jounathaen jounathaen jounathaen approved these changes

@stlankes stlankes Awaiting requested review from stlankes

Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkroening @jounathaen @stlankes