Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Cargo.toml, update Cargo.lock #136

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

mkroening
Copy link
Member

This

  1. Moves the binary source from src/bin/uhyve.rs to its standard location src/main.rs.
  2. Renames the lib target from uhyvelib to its standard uhyve.
  3. Reworks the Cargo.toml and updates Cargo.lock.

@mkroening
Copy link
Member Author

Rebased on latest master.

@mkroening mkroening force-pushed the structure branch 2 times, most recently from 3e52ab9 to a3460f2 Compare July 14, 2021 08:53
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #136 (bb47734) into master (cf646df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   33.65%   33.65%           
=======================================
  Files          17       17           
  Lines        3943     3943           
=======================================
  Hits         1327     1327           
  Misses       2616     2616           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf646df...bb47734. Read the comment docs.

@jounathaen
Copy link
Member

jounathaen commented Jul 16, 2021

Because we plan to provide different frontends for uhyve, I'm against the move of bin/uhvye.rs to main.rs and the renaming.
I like the cleaned version of the Cargo.toml though!

@mkroening
Copy link
Member Author

Will drop 1, 2.

Will research about cargo update and transitive dependencies and dependabot capabilities.

@mkroening
Copy link
Member Author

mkroening commented Jul 23, 2021

Dropped 1, 2.

Regarding omitting the patch level of the SemVer in Cargo.toml.
Bumping a dependency in Cargo.toml only causes its dependencies to update in Cargo.lock, if it is required by the new version. Otherwise, the dependency's dependencies are not touched in Cargo.lock, even if newer patch versions of those are available. Thus, we should have Dependabot update the Cargo.lock regularly anyway, which he seems to support. The explicit updates in Cargo.toml can then be reduced if we omit the patch level of the SemVer.

@mkroening mkroening changed the title Rework project structure Rework Cargo.toml, update Cargo.lock Jul 23, 2021
@mkroening mkroening force-pushed the structure branch 2 times, most recently from cd120ab to ea22465 Compare July 23, 2021 16:37
@jounathaen
Copy link
Member

I'm still unsure about how dependabot works. But we can test it and revert if it creates trouble :-)

@jounathaen
Copy link
Member

bors r+

@bors bors bot merged commit 154a291 into hermit-os:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants