Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove windows remainders #139

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Remove windows remainders #139

merged 1 commit into from
Jul 23, 2021

Conversation

mkroening
Copy link
Member

No description provided.

@mkroening mkroening requested a review from stlankes July 12, 2021 12:50
@mkroening mkroening self-assigned this Jul 12, 2021
stlankes
stlankes approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 13, 2021

Merge conflict.

@mkroening
Copy link
Member Author

@stlankes, I rebased on latest master.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #139 (0a6a092) into master (295ddc3) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   33.65%   33.67%   +0.02%     
==========================================
  Files          17       17              
  Lines        3943     3943              
==========================================
+ Hits         1327     1328       +1     
+ Misses       2616     2615       -1
Impacted Files Coverage Δ
src/vm.rs 29.10% <ø> (ø)
src/gdb_parser.rs 65.19% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295ddc3...0a6a092. Read the comment docs.

@jounathaen
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 23, 2021

Build succeeded:

@bors bors bot merged commit cf646df into hermit-os:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlankes stlankes stlankes approved these changes

Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkroening @jounathaen @stlankes