Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework error types #140

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Rework error types #140

merged 3 commits into from
Aug 21, 2021

Conversation

mkroening
Copy link
Member

Depends on #138.

This heavily reworks the error handling, introducing finer separate error types instead of one uber-error.

@mkroening mkroening self-assigned this Jul 12, 2021
@mkroening
Copy link
Member Author

Rebased on latest master.

@codecov
Copy link

codecov bot commented Jul 13, 2021 •
edited

Codecov Report

Merging #140 (4dbdf1b) into master (956dbcd) will increase coverage by 0.35%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   32.55%   32.90%   +0.35%     
==========================================
  Files          16       15       -1     
  Lines        3831     3784      -47     
==========================================
- Hits         1247     1245       -2     
+ Misses       2584     2539      -45
Impacted Files Coverage Δ
src/debug_manager.rs 0.00% <0.00%> (ø)
src/lib.rs 11.22% <0.00%> (ø)
src/linux/gdb.rs 0.00% <0.00%> (ø)
src/linux/vcpu.rs 0.00% <0.00%> (ø)
src/vm.rs 29.34% <23.80%> (+0.84%) ⬆️
src/linux/uhyve.rs 53.13% <62.50%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956dbcd...4dbdf1b. Read the comment docs.

@mkroening mkroening force-pushed the vcpu-error branch 3 times, most recently from 9b47a98 to 051aaa3 Compare July 14, 2021 08:55
@mkroening mkroening mentioned this pull request Jul 14, 2021
Merged
@mkroening mkroening force-pushed the vcpu-error branch 3 times, most recently from b2ea822 to 211ac88 Compare July 29, 2021 13:59
@mkroening mkroening changed the title [DO NOT MERGE] Rework error types Rework error types Aug 21, 2021
@mkroening mkroening removed their assignment Aug 21, 2021
@mkroening mkroening marked this pull request as ready for review August 21, 2021 12:23
@mkroening
Copy link
Member Author

This is ready for merging now.

@jounathaen
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 21, 2021

Build succeeded:

@bors bors bot merged commit c050176 into hermit-os:master Aug 21, 2021
bors bot added a commit that referenced this pull request Aug 21, 2021
@bors @mkroening
Merge #143
e264777 
143: Let VirtualCPU::run always return exit code r=jounathaen a=mkroening

Depends on  #140.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
@mkroening mkroening deleted the vcpu-error branch August 21, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jounathaen jounathaen Awaiting requested review from jounathaen

@stlankes stlankes Awaiting requested review from stlankes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkroening @jounathaen