Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove has_vm_support #152

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Remove has_vm_support #152

merged 1 commit into from
Jul 27, 2021

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Jul 23, 2021

Fixes #151.

We can just opt out all tests that contain test_vm.

@mkroening mkroening marked this pull request as ready for review July 23, 2021 17:11
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #152 (686371a) into master (cf646df) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   33.65%   33.51%   -0.14%     
==========================================
  Files          17       16       -1     
  Lines        3943     3932      -11     
==========================================
- Hits         1327     1318       -9     
+ Misses       2616     2614       -2     
Impacted Files Coverage Δ
src/vm.rs 28.50% <ø> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf646df...686371a. Read the comment docs.

@jounathaen
Copy link
Member

Elegant solution 👍
bors r+

@bors bors bot merged commit 8812049 into hermit-os:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove has_vm_support from tests
2 participants