Improve path handling

[mkroening]

This fixes a faulty PathBuf construction and lets all PathBufs be constructed via collecting instead of pushing.

Found via #192.

[codecov]

Codecov Report

Merging #190 (d257e37) into master (4115924) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   30.76%   30.75%   -0.02%     
==========================================
  Files          16       16              
  Lines        4018     4026       +8     
==========================================
+ Hits         1236     1238       +2     
- Misses       2782     2788       +6     

Impacted Files	Coverage Δ
src/vm.rs	28.47% <100.00%> (+0.12%)	⬆️
src/linux/uhyve.rs	52.88% <0.00%> (-0.89%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4115924...d257e37. Read the comment docs.

[jounathaen]

The first commit is fine, even though a // inside a path is not really faulty 😉
However, I don't really get the advantage of .iter().collect() in this case.

[jounathaen]

Just to prove my point, that this isn't faulty 😛 :
From the POSIX standard:

Multiple successive <slash> characters are considered to be the same as one , except for the case of exactly two leading <slash> characters

[mkroening]

It certainly is faulty! “Pushing an absolute path replaces the existing path” (PathBuf::push)

As for using collect over push, this is preferential, but this avoids having a mutable PathBuf and avoids spreading the path segments across multiple statements. “push is best used for dynamic situations. This is a better way to do this when you know all of the components ahead of time” (PathBuf)

[jounathaen]

Fair enough!

bors r+

[bors]

Build succeeded:

• Build (macos-latest)
• Build (ubuntu-latest)
• Cargo tests (macos-latest)
• Cargo tests (ubuntu-latest)
• Clippy
• Format
• KVM Tests
• Rusty-Hermit Kernel based integration tests