Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use cargo-llvm-cov for coverage #193

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Sep 8, 2021

Closes #124.
Fixes #198.

This adopts cargo-llvm-cov for our coverage reports, replacing the custom bash scripts.

@mkroening mkroening force-pushed the llvm-cov branch 5 times, most recently from 2101aad to a9cf46d Compare September 8, 2021 23:00
@mkroening mkroening changed the title CI: Use cargo-llvm-cov for coverage [WIP] CI: Use cargo-llvm-cov for coverage Sep 8, 2021
@mkroening mkroening marked this pull request as draft September 8, 2021 23:00
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #193 (a02f342) into master (b13a88e) will increase coverage by 21.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #193       +/-   ##
===========================================
+ Coverage   20.45%   41.89%   +21.43%     
===========================================
  Files          17       16        -1     
  Lines        2659     2454      -205     
===========================================
+ Hits          544     1028      +484     
+ Misses       2115     1426      -689     
Impacted Files Coverage Δ
src/macros.rs
src/linux/virtio.rs 13.29% <0.00%> (+4.25%) ⬆️
src/linux/uhyve.rs 61.85% <0.00%> (+7.05%) ⬆️
src/vm.rs 78.50% <0.00%> (+25.57%) ⬆️
src/linux/mod.rs 44.51% <0.00%> (+44.51%) ⬆️
src/linux/vcpu.rs 66.40% <0.00%> (+66.40%) ⬆️
src/lib.rs 100.00% <0.00%> (+89.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13a88e...a02f342. Read the comment docs.

@mkroening mkroening changed the title [WIP] CI: Use cargo-llvm-cov for coverage CI: Use cargo-llvm-cov for coverage Sep 10, 2021
@mkroening mkroening marked this pull request as ready for review September 10, 2021 14:12
@mkroening
Copy link
Member Author

This is ready for review now, but requires #199 to be solved for this to work.

@mkroening
Copy link
Member Author

@jounathaen, using rust's bundled lld instead of the system ld works around the issue, so we won't have to wait for new hardware.

@mkroening
Copy link
Member Author

bors r=jounathaen

@bors bors bot merged commit b74da25 into hermit-os:master Oct 15, 2021
@mkroening mkroening deleted the llvm-cov branch October 15, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage: Profile integration tests
2 participants