Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB: Correctly report stop reasons for watchpoints #204

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

mkroening
Copy link
Member

This fixes watchpoints in GDB (an oversight from #164).

Found while working on integration tests, @jounathaen. ;)

bors r+

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #204 (7b5c1b1) into master (d8f008d) will increase coverage by 5.58%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   14.91%   20.49%   +5.58%     
==========================================
  Files          17       17              
  Lines        2635     2654      +19     
==========================================
+ Hits          393      544     +151     
+ Misses       2242     2110     -132     
Impacted Files Coverage Δ
src/arch/x86_64/registers/debug.rs 0.00% <0.00%> (ø)
src/linux/gdb/mod.rs 0.00% <0.00%> (ø)
src/linux/uhyve.rs 54.80% <0.00%> (+6.73%) ⬆️
src/vm.rs 53.40% <0.00%> (+23.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f008d...7b5c1b1. Read the comment docs.

@bors bors bot merged commit 0c2dcc6 into hermit-os:master Sep 17, 2021
@mkroening mkroening deleted the watchpoint-fixup branch September 17, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant