Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gdbstub integration test #205

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Add gdbstub integration test #205

merged 2 commits into from
Sep 27, 2021

Conversation

mkroening
Copy link
Member

This depends on #195, but is ready for review.

@mkroening
Copy link
Member Author

The pipe command has only been implemented since GDB 10.1 in 947d39.

Thus, this depends on #199.

@mkroening
Copy link
Member Author

@jounathaen, I disabled the GDB integration test in CI.

Could we merge this now, so the test is available for running locally when adjusting the gdbstub implementation?

@mkroening
CI: Skip GDB integration test
bc5e794 
CI needs to wait for GDB 10.1 to be available.
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #205 (bc5e794) into master (40c2c27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   20.45%   20.45%           
=======================================
  Files          17       17           
  Lines        2659     2659           
=======================================
  Hits          544      544           
  Misses       2115     2115

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c2c27...bc5e794. Read the comment docs.

@jounathaen
Copy link
Member

Ok!
bors r+

@jounathaen jounathaen mentioned this pull request Sep 27, 2021
Closed
@bors
Copy link
Contributor

bors bot commented Sep 27, 2021

Build succeeded:

@bors bors bot merged commit 498b98b into hermit-os:master Sep 27, 2021
@mkroening mkroening deleted the gdb-test branch September 27, 2021 20:03
mkroening added a commit to mkroening/uhyve that referenced this pull request Sep 27, 2021
@mkroening
Fixup Cargo.lock
48e57a3 
Merging
1. hermit-os#211
followed by
2. hermit-os#205
made the lockfile inconsistent.
mkroening added a commit to mkroening/uhyve that referenced this pull request Sep 27, 2021
@mkroening
Fixup Cargo.lock
f1a865e 
Merging

1. hermit-os#211
2. hermit-os#205

in that order made the lockfile inconsistent.
@mkroening mkroening mentioned this pull request Sep 27, 2021
Merged
bors bot added a commit that referenced this pull request Sep 27, 2021
@bors @mkroening
Merge #213
6929510 
213: Fixup Cargo.lock r=mkroening a=mkroening

Merging

1. #211
2. #205

in that order made the lockfile inconsistent.

bors r+

Co-authored-by: Martin Kröning <mkroening@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jounathaen jounathaen Awaiting requested review from jounathaen

Assignees
No one assigned
Labels
Requires_HW_Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkroening @jounathaen