Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x86 dependency #248

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Remove x86 dependency #248

merged 1 commit into from
Dec 16, 2021

Conversation

mkroening
Copy link
Member

This is required for #247.

The x86 crate does not provide a configuration which can be compiled on the stable toolchain channel. The rest of uhyve has already been migrated to x86_64. The constants imported from x86 have been inserted manually.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #248 (df11d5d) into master (1ac6171) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   41.53%   41.53%           
=======================================
  Files          16       16           
  Lines        2475     2475           
=======================================
  Hits         1028     1028           
  Misses       1447     1447           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac6171...df11d5d. Read the comment docs.

@mkroening
Copy link
Member Author

bors r+

@bors bors bot merged commit 0842ea2 into hermit-os:master Dec 16, 2021
@mkroening mkroening deleted the x86-dep branch December 16, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant