Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace paging module with x86_64 pendants #266

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Replace paging module with x86_64 pendants #266

merged 1 commit into from
Jan 3, 2022

Conversation

mkroening
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 2, 2022 •
edited

Codecov Report

Merging #266 (328b2dc) into master (d46a674) will increase coverage by 0.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   63.50%   64.15%   +0.64%     
==========================================
  Files          17       16       -1     
  Lines        2458     2427      -31     
==========================================
- Hits         1561     1557       -4     
+ Misses        897      870      -27
Impacted Files Coverage Δ
src/arch/x86_64/mod.rs 71.16% <ø> (ø)
src/linux/uhyve.rs 67.94% <100.00%> (-0.09%) ⬇️
src/linux/vcpu.rs 69.97% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46a674...328b2dc. Read the comment docs.

@mkroening mkroening changed the title Rework paging module Cleanup paging module Jan 2, 2022
@mkroening mkroening force-pushed the paging branch 3 times, most recently from b5e2c1b to 6f7d22b Compare January 2, 2022 18:44
@mkroening mkroening changed the title Cleanup paging module Replace paging module with x86_64 pendants Jan 2, 2022
@mkroening mkroening marked this pull request as ready for review January 2, 2022 18:45
@mkroening mkroening marked this pull request as draft January 2, 2022 19:28
@mkroening mkroening marked this pull request as ready for review January 2, 2022 21:13
@stlankes
Copy link
Collaborator

stlankes commented Jan 3, 2022

@mkroening You have to rebase your PR.

@mkroening
Copy link
Member Author

@mkroening You have to rebase your PR.

Done 👍

stlankes
stlankes approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build succeeded:

@bors bors bot merged commit ee22950 into hermit-os:master Jan 3, 2022
@mkroening mkroening deleted the paging branch January 3, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlankes stlankes stlankes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkroening @stlankes