Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing implementation of the hypercall UHYVE_PORT_EXIT #278

Merged
merged 6 commits into from
Jan 11, 2022
Merged

add missing implementation of the hypercall UHYVE_PORT_EXIT #278

merged 6 commits into from
Jan 11, 2022

Conversation

stlankes
Copy link
Collaborator

@stlankes stlankes commented Jan 8, 2022

The hypercall was missing for MacOS on aarch64.

@codecov
Copy link

codecov bot commented Jan 8, 2022 •
edited

Codecov Report

Merging #278 (061cf25) into master (81f45ef) will increase coverage by 0.10%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   64.15%   64.25%   +0.10%     
==========================================
  Files          16       16              
  Lines        2427     2434       +7     
==========================================
+ Hits         1557     1564       +7     
  Misses        870      870
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)
src/vm.rs 79.18% <90.90%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f45ef...061cf25. Read the comment docs.

mkroening
mkroening approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jan 8, 2022
@bors @stlankes
Merge #278
0a465a3 
278: add missing implementation of the hypercall UHYVE_PORT_EXIT r=mkroening a=stlankes

The hypercall was missing for MacOS on aarch64. 

Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
@bors
Copy link
Contributor

bors bot commented Jan 8, 2022

Build failed:

@stlankes
Copy link
Collaborator Author

bors r+

bors bot added a commit that referenced this pull request Jan 10, 2022
@bors @stlankes
Merge #278
20c2d2f 
278: add missing implementation of the hypercall UHYVE_PORT_EXIT r=stlankes a=stlankes

The hypercall was missing for MacOS on aarch64. 

Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
@bors
Copy link
Contributor

bors bot commented Jan 10, 2022

Build failed:

@stlankes
allow useless conversion
167bcef 
it help to develope platform independent code
@stlankes
Copy link
Collaborator Author

bors r+

bors bot added a commit that referenced this pull request Jan 11, 2022
@bors @stlankes
Merge #278
0ba4ced 
278: add missing implementation of the hypercall UHYVE_PORT_EXIT r=stlankes a=stlankes

The hypercall was missing for MacOS on aarch64. 

Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
@bors
Copy link
Contributor

bors bot commented Jan 11, 2022

Build failed:

@stlankes
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 11, 2022

Build succeeded:

@bors bors bot merged commit b0034f9 into hermit-os:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkroening mkroening mkroening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stlankes @mkroening