Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualCPU: Take descriptive arguments #294

Merged
merged 9 commits into from
Feb 15, 2022
Merged

Conversation

mkroening
Copy link
Member

This PR moves the transmutes inside many VirtualCPU functions outside, moving the responsibility for a valid reference to the caller.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #294 (baea893) into master (3be9a3b) will decrease coverage by 0.04%.
The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   63.44%   63.40%   -0.05%     
==========================================
  Files          16       16              
  Lines        2380     2391      +11     
==========================================
+ Hits         1510     1516       +6     
- Misses        870      875       +5     
Impacted Files Coverage Δ
src/linux/vcpu.rs 69.85% <64.51%> (-0.50%) ⬇️
src/vm.rs 76.47% <66.66%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be9a3b...baea893. Read the comment docs.

Copy link
Collaborator

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors bors bot merged commit 4cb032c into hermit-os:master Feb 15, 2022
@mkroening mkroening deleted the unsafe-vcpu branch February 15, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants