-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to open login page if xterm is not installed #2
Comments
Yea. Just a black screen is not helpful at all. Having error message would be really nice. |
You can see one when you launch it in your terminal. |
Yea but to the average user there gunna open it and the window will just be blank and they wont think to launch it via the terminal and think its just broke |
Hey guys! Thanks for testing this! |
Don't forget about lxterminal and xfce4-terminal. |
That's why would be nice to have a ENV variable with the default terminal on all distros. |
You can just replace |
I saw some people saying this but on Manjaro it just says that not exists so I don't think this will work on all distros :( |
A stack exchange post says you can run |
I wonder, is it necessary to do this in a terminal emulator at all? I imagine it'd be nicer to just paste the SID into the application directly. |
AFAIK, it's for Debian/Ubuntu only. |
Seems to be available on Fedora as well. |
But not on Arch or Manjaro. |
That's true. Most of the things we have now are part of this first MVP I did, there is a lot of things that need to be improved. For some things, I'm limited on how NodeJS handle execution on external programs, like Legendary. Node does not support getting the output of the execution in real-time, I can only get the result of the call. Because Javascript is Single-threaded. So I searched everywhere and discovered that this is a feature request not implemented yet. So that's why I will never be able to show the output of the installation process, the terminal will need to be used in that case. For the login, it is possible to call I'll make this change on the next release. But after that I'll start working on personalizing the WINEPREFIX and Wine version to launch games, I think this will be the most important one. My wife is working on the Logo and on the design. So I'll make some visual improvements soon as well. |
I'm thinking a possible way of handling this better would be to team up with the Legendary developer and let Legendary expose a programmer-friendly API that can be used instead of shell commands. Granted, this would require a fair bit of work and I imagine there are more pressing issues at the moment. |
Yeah, that would be ideal. So I don't know, I think I'll need to deal with those limitations or implement an API in Javascript but I was looking for it on the EGS website and I could not find anything related to how to use theirs to implement mine. |
It is possible to call Python functions from Node.js via e.g. zerorpc though it would require you to create some sort of bindings manually I think.
Pretty sure it's all reverse-engineered. |
Nice, I'll take a look. For now, I'll replace Xterm with a shell inside the app using this: https://shelljs.io/examples. |
So, as version 0.4.0 changed the Login Flow, I'll close this Issue. Thanks! |
If xterm is not installed and you try to open Heroic it asks if you want to log in and then does nothing. You should make it so if xterm is not installed ask if it wants you to install it for you or tell you to go install it
The text was updated successfully, but these errors were encountered: