Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO_GIT_DESCRIBE_SYMBOL=main.version seems to break the build. #73

Closed
jelder opened this issue Jan 14, 2015 · 2 comments
Closed

GO_GIT_DESCRIBE_SYMBOL=main.version seems to break the build. #73

jelder opened this issue Jan 14, 2015 · 2 comments

Comments

@jelder
Copy link

jelder commented Jan 14, 2015

Adding GO_GIT_DESCRIBE_SYMBOL as described at https://github.com/kr/heroku-buildpack-go#setting-the-version-at-build-time seems to cause the build to fail.

-----> Fetching custom git buildpack... done
-----> Go app detected
-----> Using go1.2
fatal: Not a git repository (or any parent up to mount point /app)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

 !     Push rejected, failed to compile Go app

screenshot 2015-01-14 11 39 05

Repo is https://github.com/jelder/beacon/

@kr
Copy link
Contributor

kr commented Jan 17, 2015

Unfortunately, it is not possible for this feature to work correctly on heroku, both because the buildpack runs inside of a pre-commit hook, and because heroku is in the process of removing git artifacts from the build process entirely.

I'll have to remove the feature from this buildpack.

So sorry! I still want to find a way to get similar functionality, but currently it can't be done.

@kr kr closed this as completed Jan 17, 2015
@kr
Copy link
Contributor

kr commented Jan 17, 2015

Removed in 36476a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants