Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Properly handle null web_url in addons:open #1819

Open
ransombriggs opened this issue Nov 13, 2015 · 4 comments
Open

Properly handle null web_url in addons:open #1819

ransombriggs opened this issue Nov 13, 2015 · 4 comments
Assignees

Comments

@ransombriggs
Copy link
Contributor

If web_url is not defined, we bail out with a nasty message rather than a warning.

Error: Failure in opening uri nil with options {}: undefined method `to_hash' for nil:NilClass (Launchy::Error)

@ransombriggs ransombriggs self-assigned this Nov 13, 2015
@jdx
Copy link
Contributor

jdx commented Nov 16, 2015

could we move this one to the addons plugin? https://github.com/heroku/heroku-cli-addons

@ransombriggs
Copy link
Contributor Author

@dickeyxxx do you have a recommendation for what can replace launchy in node? I was thinking maybe this, but have not looked at it super deeply yet - https://www.npmjs.com/package/open

@jdx
Copy link
Contributor

jdx commented Nov 16, 2015

that project looks dead, but this looks like a decent one:
https://github.com/sindresorhus/opn

On Mon, Nov 16, 2015 at 12:57 PM Ransom Briggs notifications@github.com
wrote:

@dickeyxxx https://github.com/dickeyxxx do you have a recommendation
for what can replace launchy in node? I was thinking maybe this, but have
not looked at it super deeply yet - https://www.npmjs.com/package/open


Reply to this email directly or view it on GitHub
#1819 (comment).

@ransombriggs
Copy link
Contributor Author

That does look better, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants