This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fix unscheduling backups for some config var configurations #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some applications with aliased config vars, it's possible that the unschedule command can be too stringent in verifying the database to unschedule, making it impossible to unschedule backups without manually calling the API. This makes the unschedule verification much simpler.
msakrejda
force-pushed
the
fix-unschedule-issues
branch
from
c38c3c7
to
05310b4
Compare
|
woot woot. Thanks @uhoh-itsmaciek! Yeah, much simpler and also you know, correct. So +1! |
| @@ -513,12 +513,15 @@ def unschedule_backups | |||
| db = shift_argument | |||
| validate_arguments! | |||
|
|
|||
| if db.nil? | |||
| abort("Must specify database to unschedule backups for") | |||
| end | |||
There was a problem hiding this comment.
If there is only one schedule, should we accept no db here?
For this message, I'd add a hint:
Must specify a database. Run `heroku help pg:backups` for usage information.
There was a problem hiding this comment.
I think it does make sense to require an argument. Maybe instead of pointing people to help, we should just list what's available to unschedule instead?
There was a problem hiding this comment.
I agree we should require an argument. :)
|
@hgmnz @chadbailey59 Improved the error message / error handling. How's this look? |
|
Just got a ticket for this—any sign of merging? |
|
@uhoh-itsmaciek @tef The error messages and handling look good to me. |
jdx
pushed a commit
that referenced
this pull request
May 15, 2015
Fix unscheduling backups for some config var configurations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some applications with aliased config vars, it's possible
that the unschedule command can be too stringent in verifying
the database to unschedule, making it impossible to unschedule
backups without manually calling the API.
This makes the unschedule verification much simpler.
/cc @chadbailey59 @neovintage @hgmnz