This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

SSO with a non-trusted client causes a loop #216

Open

dmcinnes opened this issue Mar 2, 2016 · 0 comments

Contributor

dmcinnes commented Mar 2, 2016

During an SSO init, if an existing oauth dance is going on with an untrusted client, this line will show the authorization page:
https://github.com/heroku/identity/blob/master/lib/identity/login_external.rb#L24
Then when 'Authorize' button is hit we redirect back to SSO and get into a loop:
https://github.com/heroku/identity/blob/master/lib/identity/auth.rb#L231-L234

/cc @gulopine @heroku/management-experience

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.