Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Missing Sydney region #109

Open
drusellers opened this issue Aug 9, 2017 · 5 comments
Open

Missing Sydney region #109

drusellers opened this issue Aug 9, 2017 · 5 comments

Comments

@drusellers
Copy link

I'm looking at https://github.com/heroku/kensa/blob/master/lib/heroku/kensa/manifest.rb#L6 and it doesn't show sydney as a valid region. But according to https://devcenter.heroku.com/articles/add-on-manifest#api-regions it should be a valid region.

Am I missing something?

Thank you,

@drusellers
Copy link
Author

The sydney announcement: https://devcenter.heroku.com/changelog-items/980

@drusellers
Copy link
Author

We will need dublin too when that gets out of beta.

@mathias
Copy link
Contributor

mathias commented Oct 9, 2018

Hello,

Please try out our new replacement for Kensa, https://github.com/heroku/heroku-cli-addons-admin

It fetches the current public regions from the API when it generates manifests, so it should avoid needing to be updated like Kensa did.

Thanks!

@drusellers
Copy link
Author

@mathias thank you, i will indeed check this out. Unless I'm missing something this new "admin" add-on does not exercise the local apps oauth dance like Kensa does - is that correct?

@mathias
Copy link
Contributor

mathias commented Oct 11, 2018

Yes, and Kensa was never going to support the new, OAuth-based provisioning flow (which we call Provisioning API V3: https://devcenter.heroku.com/articles/add-on-partner-api-reference )

Instead, we recommend that add-on partners write integration tests in their own codebase, so that they can be run with continuous integration, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants