Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from using direct=false process types #151

Closed
edmorley opened this issue May 2, 2023 · 1 comment · Fixed by #205
Closed

Migrate away from using direct=false process types #151

edmorley opened this issue May 2, 2023 · 1 comment · Fixed by #205
Assignees

Comments

@edmorley
Copy link
Member

edmorley commented May 2, 2023

The direct=false process type mode has been removed as of Buildpack API version 0.9.

This buildpack currently uses direct=false mode, and so before we can update to Buildpack API 0.9 (and thus libcnb 0.12.0), we must migrate the buildpack to direct=true mode (and explicitly wrapping the command in bash).

An attempt at this was made in #150, however, it turns out we're blocked on cnb-shim adding support first, so that PR was closed.

Once the cnb-shim issue is resolved, we should revisit #150.

See:
#150 (comment)
heroku/cnb-shim#74

GUS-W-13119392.

@edmorley
Copy link
Member Author

Once the cnb-shim issue is resolved, we should revisit #150.

cnb-shim is now broken for other reasons (see heroku/cnb-shim#69 (comment)), so cnb-shim being modernised is no longer a blocker for upgrading procfile to newer buildpack API and direct=true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants