Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require development dependencies #39

Closed
ferhatelmas opened this issue Sep 11, 2019 · 10 comments
Closed

Don't require development dependencies #39

ferhatelmas opened this issue Sep 11, 2019 · 10 comments

Comments

@ferhatelmas
Copy link
Contributor

If deps are vendored for various reasons (i.e. cache), a lot of unnecessary code (golang-ci, go-critic) are pulled and put into git.

Suggested solution(s):

  • install under a temporary folder and use the binary
  • pull the binary directly
@freeformz
Copy link
Contributor

How are these "put into git"?

@ferhatelmas
Copy link
Contributor Author

If vendor folder is tracked by git.

Some packages are coming and going, keeping a copy in git was useful to prevent these issues and was helpful in CI to save download. With go1.13 proxy, it might not be needed, though but we need to see if it's trustable.

This is my context, here there is still an issue IMHO such that development tools shouldn't be pulled because the end user of this package doesn't care about them.

@ferhatelmas
Copy link
Contributor Author

If sounds good, happy to send a PR to take care of this.

@freeformz
Copy link
Contributor

Thanks!

I removed tools.go in this commit.

@ferhatelmas
Copy link
Contributor Author

Thanks 👍

@ferhatelmas
Copy link
Contributor Author

How about a new tag?

@ferhatelmas
Copy link
Contributor Author

@freeformz could you push a new tag please?

@ferhatelmas
Copy link
Contributor Author

@freeformz ping 😄

@freeformz
Copy link
Contributor

@ferhatelmas Sorry for the late reply. Done. I pushed v0.0.3

@ferhatelmas
Copy link
Contributor Author

@freeformz no worries, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants