-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require development dependencies #39
Comments
How are these "put into git"? |
If Some packages are coming and going, keeping a copy in git was useful to prevent these issues and was helpful in CI to save download. With go1.13 proxy, it might not be needed, though but we need to see if it's trustable. This is my context, here there is still an issue IMHO such that development tools shouldn't be pulled because the end user of this package doesn't care about them. |
If sounds good, happy to send a PR to take care of this. |
Thanks! I removed tools.go in this commit. |
Thanks 👍 |
How about a new tag? |
@freeformz could you push a new tag please? |
@freeformz ping 😄 |
@ferhatelmas Sorry for the late reply. Done. I pushed v0.0.3 |
@freeformz no worries, thank you! |
If deps are vendored for various reasons (i.e. cache), a lot of unnecessary code (golang-ci, go-critic) are pulled and put into git.
Suggested solution(s):
The text was updated successfully, but these errors were encountered: