Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to explode WAR files #25

Closed
jsimone opened this issue May 2, 2013 · 4 comments
Closed

add option to explode WAR files #25

jsimone opened this issue May 2, 2013 · 4 comments

Comments

@jsimone
Copy link
Contributor

jsimone commented May 2, 2013

Certain file access operations in Spring (among other frameworks) only work if running from an exploded WAR file.

There should be a command line flag that will cause webapp runner to explode a WAR file into a temp dir before launching.

@kvlou
Copy link

kvlou commented Jun 7, 2013

@jsimone i have that implemented as we needed it.
seems like some apps will use getRealPath from the servlet which will return
null if the war is not expanded. Usually its best to use getResourceStream, but there are some
apps that do not do this.

https://github.com/lkamenov/webapp-runner/tree/expand_war

I have added an extra option --expand-war that will expand the war and launch tomcat over that.

take a look and let me know if you would like me to submit a pull request.

Lou

@jsimone
Copy link
Contributor Author

jsimone commented Jun 7, 2013

Please do submit the pull request. Your timing is perfect. I was going to look at implementing this very soon. I'll just look to merge your work instead ;)

Thanks!

On Jun 7, 2013, at 10:24 AM, Lou Kamenov notifications@github.com wrote:

@jsimone i have that implemented as we needed it.
seems like some some apps will use getRealPath from the servlet which will return
null if the war is not expanded. Usually its best to use getResourceStream, but there are some
apps that do not do this.

https://github.com/lkamenov/webapp-runner/tree/expand_war

I have added an extra option --expand-war that will expand the war and launch tomcat over that.

take a look and let me know if you would like me to submit a pull request.

Lou


Reply to this email directly or view it on GitHub.

@kvlou
Copy link

kvlou commented Jun 7, 2013

Just did that, however it includes the base-url for proxys there as well. You can just pick what you need from there.

@jsimone
Copy link
Contributor Author

jsimone commented Jul 1, 2013

This is released in 7.0.40.0

@jsimone jsimone closed this as completed Jul 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants