Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add visual aid to heronarts.lx.color.ColorParameter #20

Closed
drichelson opened this issue Jan 24, 2019 · 8 comments
Closed

Comments

@drichelson
Copy link
Member

drichelson commented Jan 24, 2019

This is a handy widget! it would be cool to add a visual aid so that it's clear what color is represented by the 3 parameters. One thought is to group them and make their background the currently selected color..
I realize at least part of this implementation would happen in P3LX..

@mcslee
Copy link
Member

mcslee commented Jan 24, 2019

Hey Dan - just want to make sure I understand what you're asking about here. Which thing are you referring to as the handy widget? Do you just mean the ColorParameter helper itself, or are you referring to one of the existing color-selection UIs?

Shoot me a screen-shot perhaps of which bit you're talking about?

@drichelson
Copy link
Member Author

I'm referring to the ColorParameter helper class itself. Here is a screenshot with a box drawn around the 3 knobs for my ColorParameter:
image

  1. It would be cool to add a box like I did so the grouping of them is more intuitive.
  2. It would also be cool to have something indicating the currently selected color.

It could also be cool to have this involve a color picker, but maintain support for modulation...

@mcslee
Copy link
Member

mcslee commented Jan 24, 2019

Gotcha. I made something for this once, but I should really make it more generic. There's a custom color picker UI for the SolidPattern class in P3LX.

https://github.com/heronarts/P3LX/blob/master/src/main/java/heronarts/p3lx/pattern/SolidPattern.java

screen shot 2019-01-24 at 2 42 51 pm

This could probably be more dense, it's kind of a big UI. I could def make this this into a single reusable component though. Would that work for you?

@drichelson
Copy link
Member Author

Nice! that looks good. My particular pattern has multiple colors and I'd like to oscillate their values independently.

@mcslee
Copy link
Member

mcslee commented Jan 25, 2019

Cool - on my TODO list to make this generic. Coming soon...

Feel free to just hijack that code in the meantime if you like.

@jkbelcher
Copy link
Collaborator

Upvote to make this generic and easy to use. I frequently have 1-2 HSB colors as pattern parameters so would use this often. Thanks!

@drichelson
Copy link
Member Author

I'm resurfacing after a long break from LX etc. Is this still outstanding? If so I may take a stab at building it.

@mcslee
Copy link
Member

mcslee commented Oct 6, 2020

Hey Dan! There is a UIColorPicker helper for this now:
https://github.com/heronarts/P3LX/blob/dev/src/main/java/heronarts/p3lx/ui/component/UIColorPicker.java

Might not be exactly what you're looking for, but renders a color box which you can click on for a context menu with more detailed color section controls (which should be midi/modulation-mappable).

@mcslee mcslee closed this as completed Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants