Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with babel.config.js #2

Open
gnuletik opened this issue Dec 7, 2018 · 14 comments
Open

Not compatible with babel.config.js #2

gnuletik opened this issue Dec 7, 2018 · 14 comments

Comments

@gnuletik
Copy link

gnuletik commented Dec 7, 2018

Hi, thanks for your plugin !

This module is not compatible with babel.config.js file because find-babel-config does not.
See tleunen/find-babel-config#31

Thanks !

@HeroProtagonist
Copy link
Owner

@gnuletik Thanks for the feedback. I am going to look at making a PR to that repo. Do you have an example project using babel.config.js

@gnuletik
Copy link
Author

Thanks for your time :)

Here is an example babel.config.js file

module.exports = function () {
  return {
    presets: ['babel-preset-expo'],
    plugins: [
      ['module-resolver', {
        alias: {
          '~components': './src/components',
          '~utils': './src/utils',
        },
        cwd: 'packagejson',
      }],
    ],
  };
};

@HeroProtagonist
Copy link
Owner

@gnuletik I have opened a PR to find-babel-config. This should fix the issue.

Until it gets reviewed/merged I am going to do work on config-support branch for this package and reference my fork.

When you have time please let me know if that branch works with your project using the babel.config.js

@gnuletik
Copy link
Author

gnuletik commented Dec 19, 2018

Thanks !

How can I test locally ?
If I install the package from your branch

yarn add --dev 'HeroProtagonist/eslint-plugin-module-resolver#config-support

eslint does not find the plugin

ESLint: 5.9.0.
ESLint couldn't find the plugin "eslint-plugin-module-resolver". This can happen for a couple different reasons:
...

This also occurs when using the master branch

@gnuletik
Copy link
Author

Okay, I succeed to install the plugin from the github branch with

cd node_modules/eslint-plugin-module-resolver/
yarn install
yarn run babel lib --out-dir dist

I tested the plugin, however, find-babel-config throws an error because the api parameter is missing when calling the babel.config.js function.
Sorry, I didn't include the api parameter from babel.config.js in my previous comment.

If I disable the cache, babel throws an error and eslint-plugin-import does not work anymore.

babel.config.js

module.exports = function (api) {
  api.cache(true);
  return {
    presets: ['babel-preset-expo'],
    plugins: [
      ['module-resolver', {
        alias: {
          '~components': './src/components',
          '~utils': './src/utils',
        },
        cwd: 'packagejson',
      }],
    ],
  };
};

.eslintrc.json

{
    "env": {
        "node": true,
        "browser": true,
        "es6": true
    },
    "parser": "babel-eslint",
    "extends": "airbnb",
    "rules": {
        "react/jsx-filename-extension": [1, { "extensions": [".js"] }],
        "module-resolver/use-alias": 2
    },
    "settings": {
        "import/resolver": {
            "babel-module": {}
        }
    },
    "plugins": [
        "module-resolver"
    ]
}

@DEfusion
Copy link

I'm still getting this error with these versions:

eslint-plugin-module-resolver@^0.10.0:
  version "0.10.0"

find-babel-config@^1.1.0, find-babel-config@^1.2.0:
  version "1.2.0"

@HeroProtagonist
Copy link
Owner

@DEfusion Hi! Could you share the repository (if public) or config files that represent the problem. Will make it easier to debug. Thanks

@nucab
Copy link

nucab commented May 26, 2020

for still looking the solution. setting the preset only in production env fix my issue

{
  ...
  env: {
    production: {
      presets: ['react-app'],
    },
  },
}

@HeroProtagonist
Copy link
Owner

@gnuletik - I am wondering if the latest version has fixed this and this issue can be closed

@gnuletik
Copy link
Author

gnuletik commented Jan 5, 2021

@HeroProtagonist Thanks for the feedback ! I'm not using this lib anymore so I cannot test it right now.

@ryanjwessel
Copy link

I am trying version 1.2.0, but I can't seem to get the linter to warn when using any relative paths. My project is using a babel.config.js file, but it also wouldn't work with a .babelrc.json for what it's worth.

@ease-space
Copy link

ease-space commented Jun 6, 2021

@HeroProtagonist I am trying version 1.3.0 not worked with babel.config.js

@HeroProtagonist
Copy link
Owner

Was it working in 1.2.0 for you?

@ease-space
Copy link

@HeroProtagonist No, v1.2.0 not worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants