Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CG extension overloads are declared internal but then used publicly #27

Closed
jimsmithm3 opened this issue Jan 8, 2017 · 1 comment

Comments

@jimsmithm3
Copy link

What I ran into was pulling your ImageGallery example code into my project as a baseline for modification to my needs.

What I immediately ran into was in ImageViewController.swift on line 67

ImageGallery/ImageViewController.swift:67:38: Binary operator '+' cannot be applied to two 'CGPoint' operands.

This is declared internal in CG+Hero.swift on line 76. Since I am pulling this in as a pod while the example code is just an internal library I get the error and it doesn't.

I had to change the CG+Hero.swift to public to get that code to compile in my project. Should all the overloads just be made public? I am just starting to use this maybe there is a reason not to do that. I would rather use pods than copy it locally if possible.

Thanks and this library really looks like it's going to be very useful.

@jimsmithm3 jimsmithm3 changed the title The CG overload extensions are declared internal but then used publicly The CG extension overloads are declared internal but then used publicly Jan 8, 2017
@lkzhao
Copy link
Collaborator

lkzhao commented Jan 8, 2017

I don't really want to expose that extension since it is half baked. If I expose them, you will get a duplicate implementation error during compilation if you also happen to use any of the swift extension libraries like SwifterSwift or ExSwift. If you need the file you can copy it locally. Or I would recommend checking out SwifterSwift

@lkzhao lkzhao closed this as completed Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants