Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can only be used in Present ViewController? #50

Closed
XHQFighting opened this issue Jan 19, 2017 · 3 comments
Closed

Can only be used in Present ViewController? #50

XHQFighting opened this issue Jan 19, 2017 · 3 comments

Comments

@XHQFighting
Copy link

In the Demo, I put the “present(vc, animated: true, completion: nil)” replaced with “self.navigationController?.pushViewController(vc, animated: true)”,the view's animation effects disappear

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 19, 2017

@lkzhao lkzhao closed this as completed Jan 19, 2017
@deepaksuthar
Copy link

deepaksuthar commented May 8, 2020

@XHQFighting did you get it working as I am facing the same problem.
with works with “present(vc, animated: true, completion: nil)”
but not with “self.navigationController?.pushViewController(vc, animated: true)”

@lkzhao can you please elaborate ?

Thank you

FOUND THE PROLEM

I was overriding the navigationController?.delegate
so it was not working.
Might be helpful for someone else.

Thank you guys for such library.

@kostapappas-Desquared
Copy link

best solution is here
#25 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants