Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI for changing the "Max. memory" profile setting #153

Closed
herzbube opened this issue Apr 21, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@herzbube
Copy link
Owner

commented Apr 21, 2013

Currently it is very easy for the user to change the "Max. memory" profile setting to a value that is too high. The UI should be improved so that the user is amply warned when she changes that setting.

  • Create a dedicated screen for changing the setting
  • When she changes the setting (possibly only when she increases the value), the user must confirm that she knows what she is doing
  • Add information about how much memory all known iOS device have
  • Add a tappable link that takes the user to the Wikipedia page where all iOS devices with their capabilities are listed

@ghost ghost assigned herzbube Apr 21, 2013

@herzbube

This comment has been minimized.

Copy link
Owner Author

commented May 9, 2013

The last two points have been scrapped, instead the view now limits the upper limit of the setting to a fraction of the amount of physical memory that the device has. The fraction increases with the amount of physical memory. Thresholds have been set like this:

  • <= 256 MB: Upper limit is 1/4 of physical memory. This is probably a bit too aggressive: On an iPhone 3GS setting "Max. memory" to the upper limit of 64 MB crashes the app if the user also uses zoom. Still, I wanted to give the user the freedom to not use zoom in favor of giving more memory to the GTP engine.
  • 257-512 MB: Upper limit is 1/2 of physical memory. This should be fine, even if the user uses zoom.
  • = 512 MB: Upper limit is 2/3 of physical memory. This is probably a bit too conservative, but better be safe than sorry, and it's still an improvement over the old hard-coded upper limit of 512 MB.

@herzbube herzbube closed this in 99ba9ee May 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.