Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow domains in the ip field #14

Open
notcooler opened this issue Sep 20, 2023 · 2 comments
Open

Allow domains in the ip field #14

notcooler opened this issue Sep 20, 2023 · 2 comments
Labels
enhancement New feature or request network involves low level networking (e.g. wol protocol)

Comments

@notcooler
Copy link

No description provided.

@herzhenr
Copy link
Owner

This would be a nice addition since the wake on lan protocol which I use already supports domains. In the network discovery, domain names of devices are currently shown as the device name. I could implement an option to use this name as the domain name to ping the device as well. Since I also want to support IPv6 addresses Issue #4, I will implement these features together.

@herzhenr herzhenr added enhancement New feature or request network involves low level networking (e.g. wol protocol) labels Sep 22, 2023
@LandazuriPaul
Copy link

Hello,

First, I'd like to thank you @herzhenr for this project, which is yet another great open source tool! \o/

I tested the app and it looks, feels and works great. So I'd really like to stick to it entirely, but at the moment I can't since I also want to be able to wake my home server remotely (using wake-on-wan). But this would only be possible if this feature is implemented. So for now, I've got to use another app which tries to upsell me on dumb features I don't need on top of not feeling as simple and clean as yours.

Here are a couple of small suggestions I would add to this feature request:

  • in the app I was using on Android, the label for the address was IP/Router Address to explicit the fact that both IP and FQDN addresses could be accepted. I imagine that if you were to implement this feature, it would be nice to make it visible in a similar way (or any other way really, just suggesting the simplest alternative I imagine). 🙂
  • when choosing a different port number than the usual 7 or 9 (very likely when using wake-on-lan as usually people would use port-forwarding a rule at the router level to avoid exposing 7 or 9), the Port field behaves in an unexpected way (see screenshot below):
    • We can input text. I would have expected a numeric field as no text can be used for a port number.
    • The other port options can still be selected, which is a bit confusing as we're not entirely sure what the port is actually going to be used. I noticed that the port field gets updated when selecting 7 or 9. Maybe one way to fix this is to have a third chip option labelled other which reveals/enables the free numeric form if selected. Also this means that when people switch from other to 7 or 9, they don't get their custom value overridden (which is currently the case).

IMG_2CC1887FC777-1

Have a great one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request network involves low level networking (e.g. wol protocol)
Projects
None yet
Development

No branches or pull requests

3 participants