Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM21 integration #7

Open
PigUnderRoof opened this issue Dec 14, 2021 · 2 comments
Open

DM21 integration #7

PigUnderRoof opened this issue Dec 14, 2021 · 2 comments

Comments

@PigUnderRoof
Copy link

Hi @hesther ,

Deepmind released a functional approximation, DM21, claiming they didn't break the fractional charge and spin constraints, which seems to essential to molecule DFT. But it is built with PYSCF, will you consider integrating it in this project?

Best,

Chao

@hesther
Copy link
Owner

hesther commented Dec 14, 2021

Mmh, might be worth a try. I am currently implementing a simpler machine learning model for approximating partial charges, but might look into DM21 more. I have never used PySCF before, have you? I wonder what methods they provide for partial charge calculations (but can look it up). My todo list is filling up quickly, so might not be able to get around to this fast.

@PigUnderRoof
Copy link
Author

Hi @hesther,

Thanks for your work. Sorry for the late reply.

I was my first try with PySCF, following DM21 guidance. In my understanding (might be not accurate), they only provided a modified method for electron density estimation, and PySCF doesn't has a esp charge module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants