Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some elements of the GUI remain untranslated #930

Closed
Wibol opened this issue Jul 13, 2020 · 4 comments
Closed

Some elements of the GUI remain untranslated #930

Wibol opened this issue Jul 13, 2020 · 4 comments
Labels
enhancement Enhancement to existing functionality help needed Extra attention is needed interface Issues related to the interface and backend admin translations Issues related to interface translations
Projects

Comments

@Wibol
Copy link
Contributor

Wibol commented Jul 13, 2020

Some elements of the GUI remain untranslated because their translation string does not exist or are not used in en.php or es.php languages files:

Missing strings:
'Forwarding' (in column title) > https://host.domain.tld:8083/list/mail/?domain=domain.tld
'%s backups' (in footer) > https://host.domain.tld:8083/list/backup/
'%s firewall rules' (in footer) > https://host.domain.tld:8083/list/firewall/
'%s banned IP addresses' (in footer) > https://host.domain.tld:8083/list/firewall/banlist/

Unused tags:
'Cron Job' (in left column title) > https://host.domain.tld:8083/list/cron/
'Host' (in Databases, third form text box title) > https://host.domain.tld:8083/edit/server/
'Host' (in Backups, Remote backup, second form text box title) > https://host.domain.tld:8083/edit/server/

The same translation string (‘Records’) is used in the top navigation menu and the DNS section, which makes the work complicated at least in Spanish. Different translation strings should be used for those items. The Records tab links to user accounts list in admin session and to web domains list in user session, so I think a more generic name should be used like: Management, Administration, Index or Home.

My Hetzner VPS is running HesiaCp v1.2.0 recently upgraded on Debian 9.

@ghost
Copy link

ghost commented Jul 13, 2020

Hi @Wibol, thanks for reporting your findings. We'll add the missing strings to en.php with initial translations to other languages which can then be updated as necessary, if you find any more strings which need to be adjusted please let us know.

@jaapmarcus jaapmarcus added this to To do in v1.2.x via automation Jul 14, 2020
@jaapmarcus jaapmarcus moved this from To do to In progress in v1.2.x Jul 14, 2020
@jaapmarcus
Copy link
Member

Added the following strings:

aa30f5a#diff-cbc962e9856c73ab5a83d22a0134cbd0

Feel free to improve my Google translate Spanish.

@ghost ghost added enhancement Enhancement to existing functionality interface Issues related to the interface and backend admin translations Issues related to interface translations help needed Extra attention is needed labels Jul 25, 2020
@jlguerrerosanz
Copy link
Contributor

I just commented my translation. If you need more help, let me know

@ScIT-Raphael
Copy link
Member

@jlguerrerosanz uos, posted it under the wrong thread, but still the same: #1354 (comment)

Language handling has been reworked :).

v1.2.x automation moved this from In progress to Done Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing functionality help needed Extra attention is needed interface Issues related to the interface and backend admin translations Issues related to interface translations
Projects
No open projects
v1.2.x
  
Done
Development

No branches or pull requests

4 participants