feat: add nomad installation docs #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamil7
reviewed
Aug 1, 2023
|
Ready for review |
jooola
reviewed
Aug 14, 2023
jooola
reviewed
Aug 14, 2023
jamil7
reviewed
Aug 14, 2023
jooola
requested changes
Aug 14, 2023
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
apricote
reviewed
Aug 14, 2023
Co-authored-by: Julian Tölle <julian.toelle97@gmail.com>
apricote
reviewed
Aug 14, 2023
Co-authored-by: Julian Tölle <julian.toelle97@gmail.com>
jooola
approved these changes
Aug 14, 2023
|
common problem on GH, my PR doesn't have access to your secrets, tests may fail. ;) |
Yea, but I am confident that a markdown document won't break our e2e tests ;) |
|
One thing I forgot, but I can also add it right before merging, it would be nice to link to the new docs from our readme: https://github.com/hetznercloud/csi-driver#getting-started |
apricote
approved these changes
Aug 14, 2023
|
added "not officially supported" I guessed? |
Yea, until we have automated tests for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #331