Fix firewall rule description

hetznercloud · Aug 5, 2021 · e951e99 · e951e99
1 parent e3eca12
commit e951e99
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/hcloud/schema.go b/hcloud/schema.go
@@ -759,6 +759,7 @@ func FirewallFromSchema(s schema.Firewall) *Firewall {
 			DestinationIPs: destinationIPs,
 			Protocol:       FirewallRuleProtocol(rule.Protocol),
 			Port:           rule.Port,
+			Description:    rule.Description,
 		})
 	}
 	return f

diff --git a/hcloud/schema_test.go b/hcloud/schema_test.go
@@ -2722,7 +2722,8 @@ func TestFirewallFromSchema(t *testing.T) {
 				"ff21:1eac:9a3b:ee58:5ca:990c:8bc9:c03b/128"
 			  ],
 			  "protocol": "tcp",
-			  "port": "80"
+			  "port": "80",
+			  "description": "allow http in"
 			}
 		],
 		"applied_to": [
@@ -2777,6 +2778,9 @@ func TestFirewallFromSchema(t *testing.T) {
 	if *firewall.Rules[0].Port != "80" {
 		t.Errorf("unexpected Rule Port: %s", *firewall.Rules[0].Port)
 	}
+	if *firewall.Rules[0].Description != "allow http in" {
+		t.Errorf("unexpected Rule Description: %s", *firewall.Rules[0].Description)
+	}
 	if len(firewall.AppliedTo) != 2 {
 		t.Errorf("unexpected UsedBy count: %d", len(firewall.AppliedTo))
 	}