fix: raise warnings for the ImagesClient.get_by_name deprecation
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
changed the title
ImagesClient.get_by_name deprecation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
=======================================
Coverage 92.84% 92.85%
=======================================
Files 65 65
Lines 2881 2883 +2
=======================================
+ Hits 2675 2677 +2
Misses 206 206 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Apr 2, 2024
|
Should we add some docs fors devs for deprecating methods? |
Yup, I can do that in a later PR. |
jooola
changed the title
ImagesClient.get_by_name deprecationImagesClient.get_by_name deprecation
jooola
pushed a commit
that referenced
this pull request
Apr 2, 2024
🤖 I have created a release *beep* *boop* --- ## [1.35.0](v1.34.0...v1.35.0) (2024-04-02) ### Features * add `include_deprecated` option when fetching images by name ([#375](#375)) ([6d86f86](6d86f86)) ### Bug Fixes * raise warnings for the `ImagesClient.get_by_name` deprecation ([#376](#376)) ([b24de80](b24de80)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing warning and sphinx deprecation notice on an already deprecated method.