fix: update integrations metadata identifier #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
approved these changes
Nov 8, 2023
|
@nywilken Could you please take a look? I didn't find examples of such change in the other transfer examples you send me (digitalocean and linode). |
|
Hi @jooola this is correct. We didn't have the product integrations in place when we transferred the other plugins, which is why there are no previous examples. Thanks for calling this out. This change looks good to me. If you wish to test you can use the manual notify release action to re-trigger a deploy for 1.2.0, which I see you were able to deploy https://developer.hashicorp.com/packer/integrations?filter=Hetzner |
jooola
pushed a commit
that referenced
this pull request
Nov 8, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.1](v1.2.0...v1.2.1) (2023-11-08) ### Bug Fixes * update integrations metadata identifier ([#119](#119)) ([402c146](402c146)), closes [#95](#95) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that this change was missing from the previous transfer pull request #95