feat: add labels options to server and ssh keys #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding labels to the temporary server and ssh key objects which are needed to create the snapshot. This is needed in some use cases where e.g. packer build stops unexpectedly due to a SIGKILL and cannot shut down properly. In order to realize that the respective server and ssh key are orphaned, labels are needed. Signed-off-by: janiskemper <janis.kemper@syself.com>
apricote
approved these changes
Dec 12, 2023
|
sorry.. I had too many things on my table. Thanks a lot for continuing this! |
jooola
pushed a commit
that referenced
this pull request
Jan 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.1...v1.3.0) (2024-01-09) ### Features * add labels options to server and ssh keys ([#128](#128)) ([3f7dcae](3f7dcae)) * use existing IP for server create ([#144](#144)) ([1ebdfe7](1ebdfe7)) ### Bug Fixes * do not pass nil error to error handler ([#145](#145)) ([e742263](e742263)) * improve logs messages and error handling ([#139](#139)) ([2f2bcf1](2f2bcf1)) * improve missing hcloud token error ([#138](#138)) ([e47f476](e47f476)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #92
Adding labels to the temporary server and ssh key objects which are needed to create the snapshot.
This is needed in some use cases where e.g. packer build stops unexpectedly due to a SIGKILL and cannot shut down properly. In order to realize that the respective server and ssh key are orphaned, labels are needed.