fix(ssh-key): data inconsistency with empty label objects #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have manually tested the various combinations for empty
We plan to add some more detailed tests in the coming weeks, but wanted to get this fix out immediately. |
When we implemented the Label helper we added some extra logic that
handled the difference between the `label` attribute default (null) and
the Hetzner Cloud API default (`{}`). This worked well in our test
cases, but breaks if you pass an empty object to the attribute:
When applying changes to hcloud_ssh_key.this, provider
"provider[\"registry.terraform.io/hetznercloud/hcloud\"]" produced
an unexpected new value: .labels: was cty.MapValEmpty(cty.String),
but now null.
We have now fixed this by setting the default of the labels field to
an empty object to match the return value of the API. With this, we no
longer need the workaround to handle null labels in Terraform config.
Fixes #921
apricote
force-pushed
the
ssh-key-label-inconsistency
branch
from
dd8caa4
to
f7991a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
=======================================
Coverage 69.76% 69.76%
=======================================
Files 63 63
Lines 7938 7938
=======================================
Hits 5538 5538
Misses 1701 1701
Partials 699 699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jooola
approved these changes
May 2, 2024
apricote
pushed a commit
that referenced
this pull request
May 3, 2024
🤖 I have created a release *beep* *boop* --- ## [1.47.0](v1.46.1...v1.47.0) (2024-05-02) ### Features * test with Terraform 1.8 ([#919](#919)) ([800a66c](800a66c)) ### Bug Fixes * **ssh-key:** data inconsistency with empty label objects ([#922](#922)) ([7e1bf2c](7e1bf2c)), closes [#921](#921) * **subnet:** handle new error message for deleting subnets with attached resources ([#923](#923)) ([932c47b](932c47b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we implemented the Label helper we added some extra logic that handled the difference between the
labelattribute default (null) and the Hetzner Cloud API default ({}). This worked well in our test cases, but breaks if you pass an empty object to the attribute:We have now fixed this by setting the default of the labels field to an empty object to match the return value of the API. With this, we no longer need the workaround to handle null labels in Terraform config.
Fixes #921