Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netty HTTP client adapter #544

Open
jaguililla opened this issue Sep 16, 2022 · 11 comments
Open

Add Netty HTTP client adapter #544

jaguililla opened this issue Sep 16, 2022 · 11 comments
Assignees
Labels
enhancement good first issue Earn your wings at the OSS community help wanted

Comments

@jaguililla
Copy link
Member

jaguililla commented Sep 16, 2022

Implement an HTTP client adapter using Netty. This new module should be located at the http/http_client_netty directory.

The http_client_jetty module can be used as a guide.

http_client_jetty integration tests are located in http_test/src/test/kotlin/com/hexagonkt/http/test/AdapterExamplesTest.kt, the Netty adapter should copy them into its module tests (same as http_client_jetty) and make them pass with the new adapter.

For information on how to build the project and pass the tests please refer to the contributing guide.

If you have any question or suggestion, please feel free to use this issue's comments to discuss them 🙂

@CaptainDaVinci
Copy link

Hi, I would like to work on this issue ✋🏼

I'm new to the project so I'll get started with reading the documentation.

@jaguililla
Copy link
Member Author

That's great @CaptainDaVinci ...

Just take a look at the Contributing Guide to get started and don't hesitate to ask for help

I will assign this issue to you and move it to the 'in progress' status.

Thank you very much for your help and support!

@theAkito
Copy link

@CaptainDaVinci Are you still working on this?

@CaptainDaVinci
Copy link

@theAkito yes, I've started work on this but haven't been able to complete it. I'm looking to create a PR by this weekend.

@drugwho
Copy link

drugwho commented Dec 18, 2022

@jaguililla If this task is still available I'd like to work on it.

@jaguililla
Copy link
Member Author

Sorry for the delay @drugwho I guess @CaptainDaVinci is not working on this task currently, I'll assign it to you, if he wants to share some pointers or collaborate with you, that would be great!

@drugwho
Copy link

drugwho commented Jan 20, 2023

thanks @jaguililla i'll get to it this weekend

@jaguililla
Copy link
Member Author

Hello, is there any progress on this task?

@jaguililla jaguililla removed help wanted good first issue Earn your wings at the OSS community labels Apr 12, 2023
@jaguililla jaguililla changed the title Add Netty HTTP client Add Netty HTTP client adapter Aug 28, 2023
@jaguililla jaguililla added help wanted hacktoberfest good first issue Earn your wings at the OSS community labels Aug 28, 2023
@ReccaFlames
Copy link

Hello @jaguililla I would like to work on this task if it is free 🙂

@jaguililla
Copy link
Member Author

Sure thing, be my guest... I'll assign it to you and move it to 'In Progress'.

Remember to check the contributing.md file to build and test the project.

And of course, if you've got any problem, just contact me... Thanks for your interest and helping the project.

Happy coding!

@jaguililla
Copy link
Member Author

Hello, is there any progress on this task?

@jaguililla jaguililla self-assigned this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Earn your wings at the OSS community help wanted
Projects
Status: In Progress
Development

No branches or pull requests

5 participants