Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode vim mode does not work or it works #993

Closed
ilyar opened this issue Apr 2, 2021 · 8 comments · Fixed by #1134
Closed

Mode vim mode does not work or it works #993

ilyar opened this issue Apr 2, 2021 · 8 comments · Fixed by #1134

Comments

@ilyar
Copy link
Contributor

ilyar commented Apr 2, 2021

The vim mode does not work or it works, but my expectations do not match. I assume this is vim editor emulation mode. At the moment I'm observing that vim switch has no effect on editor's behavior, I checked it in Google Chrome Version 89.0.4389.90.

How should vim mode work?

@ReDBrother
Copy link
Collaborator

ReDBrother commented Apr 2, 2021

I assume this is vim editor emulation mode

Yes, we are using https://www.npmjs.com/package/monaco-vim. It only adds keybindings for monaco editor. We will check, thanks.

@ilyar
Copy link
Contributor Author

ilyar commented Apr 2, 2021

I checked monaco-vim https://monaco-vim.ilyar.repl.co/ it is ok, but in codebattle editor not same

@ReDBrother
Copy link
Collaborator

ReDBrother commented Apr 2, 2021

import { initVimMode } from 'monaco-vim';

vim: () => initVimMode(this.editor, this.statusBarRef.current),

@ReDBrother
Copy link
Collaborator

ReDBrother commented Apr 2, 2021

Maybe some keybindings are being replaced by custom rules in Editor.jsx. I'don't know yet.

@vtm9
Copy link
Contributor

vtm9 commented Apr 21, 2021

Using vim mode all the time, didn't have any problems.

@vtm9 vtm9 added the bug label Apr 21, 2021
@vtm9
Copy link
Contributor

vtm9 commented Apr 21, 2021

cannot reproduce

@Layerex
Copy link

Layerex commented Jun 15, 2022

I checked monaco-vim https://monaco-vim.ilyar.repl.co/ it is ok, but in codebattle editor not same

Same. In codebattle vim mode doesn't work, but it does work in https://monaco-vim.ilyar.repl.co/.

Browser: Chromium 102.

@vtm9
Copy link
Contributor

vtm9 commented Sep 3, 2022

Yeah, it doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants