Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not totally replace Swig with Nunjucks? #1593

Closed
mamboer opened this issue Nov 17, 2015 · 10 comments
Closed

Why not totally replace Swig with Nunjucks? #1593

mamboer opened this issue Nov 17, 2015 · 10 comments

Comments

@mamboer
Copy link

@mamboer mamboer commented Nov 17, 2015

I notice that the code base of Hexo uses Swig along with Nunjucks.
Swig isn't maintained currently, why not just replace all the Swig stuff with Nunjucks

@PhiLhoSoft
Copy link

@PhiLhoSoft PhiLhoSoft commented Nov 20, 2015

Swig, Nunjucks, EJS, that's lot of template engines for one application...
Alas, if we use an existing template, EJS is probably mandatory, as all templates I looked at use it.
Unless there is an EJS to Nunjucks converter somewhere?

@ivanoats
Copy link

@ivanoats ivanoats commented Jan 31, 2016

I'd agree with @mamboer on this one. It's a bit scary to look at the giant "unmaintained" notice on Swig's github repo. Nunjucks is the successor to Swig. This question should be answered because the current Hexo Docs say that Swig is the default tempting language. https://hexo.io/docs/themes.html#layout

An alternative to Nunjucks may be liquid-node which may be better because Liquid is the default templating language for Jekyll.

@leesei
Copy link
Member

@leesei leesei commented Feb 23, 2016

I see a recent commit 35342cb to replace swig in creating post.
But swig renderer is still registered in the Hexo core, this is against to movement to modularize Hexo.
The default theme Landscape uses ejs, our setup teaches users to install external renderer. I think swig has served it's purpose and its time to say goodbye.

@tommy351, maybe we should announce swig renderer's deprecation and remove it altogether in the next release.

@Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Feb 23, 2016

Agree with @leesei too.

@chawyehsu
Copy link
Contributor

@chawyehsu chawyehsu commented Nov 1, 2016

Swig is dead. paularmstrong/swig@70a1c88

@NoahDragon
Copy link
Member

@NoahDragon NoahDragon commented Nov 2, 2016

Agree.

@dumindu
Copy link

@dumindu dumindu commented Feb 25, 2018

Any update on this?

@NoahDragon
Copy link
Member

@NoahDragon NoahDragon commented Mar 15, 2018

@dumindu please check the status of PR #2903

@curbengh curbengh removed the question label Dec 9, 2019
@bibichuan
Copy link

@bibichuan bibichuan commented Dec 25, 2019

Agree with @leesei too.Hexo-renderer-nunjucks on npm is also no longer maintained, I don't know why.

@stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Feb 27, 2020

The migration to Nunjucks is almost complete. The discussion can go here: #2903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet