fix(responsetranslator): fixed preg_quote usage, added delimiter

centralnicgroup-opensource · May 21, 2021 · 8988cdd · 8988cdd
1 parent c513fe6
commit 8988cdd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/ResponseTranslator.php b/src/ResponseTranslator.php
@@ -69,7 +69,7 @@ public static function translate($raw, $cmd, $ph = [])
             // match the response for given description
             // NOTE: we match if the description starts with the given description
             // it would also match if it is followed by additional text
-            $qregex = "/description=" . preg_quote($regex) . "/i";
+            $qregex = "/description=" . preg_quote($regex, "/") . "([^\r]+)?/i";
             if (preg_match($qregex, $newraw)) {
                 // replace command place holder with API command name used
                 if (isset($cmd["COMMAND"])) {

diff --git a/tests/ResponseTranslatorTest.php b/tests/ResponseTranslatorTest.php
@@ -137,7 +137,7 @@ public function testCheckDomainTransferTranslation(): void
         // mixed status `locked` and Wrong Auth
         $r = new R("[RESPONSE]\r\ncode=219\r\ndescription=Request is not available; DOMAIN TRANSFER IS PROHIBITED BY STATUS (clientTransferProhibited)/WRONG AUTH\r\nEOF\r\n", $cmd);
         $this->assertEquals(219, $r->getCode());
-        $this->assertEquals("This Domain is locked. Initiating a Transfer is therefore impossible.", $r->getDescription());
+        $this->assertEquals("This Domain is locked and the given Authorization Code is wrong. Initiating a Transfer is therefore impossible.", $r->getDescription());
 
         // Age of the Domain <= 60d
         $r = new R("[RESPONSE]\r\ncode=219\r\ndescription=Request is not available; DOMAIN TRANSFER IS PROHIBITED BY AGE OF THE DOMAIN\r\nEOF\r\n", $cmd);