Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subdivision names with codes #480

Merged
merged 2 commits into from
Dec 24, 2017
Merged

Add subdivision names with codes #480

merged 2 commits into from
Dec 24, 2017

Conversation

md-hamed
Copy link

Resolves #479.

@md-hamed
Copy link
Author

@rposborne

  • Please note that I haven't used html_safe here for the name of the subdivision as done in all_names_with_codes as I see no reason for using it in the first place. Please confirm that this is true.
  • There are some subdivisions with no name. Is there a plan to resolve this by adding the missing names to the subdivision data or should I fallback to the English translation?

@md-hamed
Copy link
Author

@rposborne any updates?

@rposborne
Copy link
Collaborator

@md-hamed Sorry I totally missed your pr. I think neglecting html_safe is fine, and I am not totally sure why it is there either.

@rposborne rposborne merged commit 097d92f into countries:master Dec 24, 2017
@rposborne
Copy link
Collaborator

@md-hamed 2.1.3 released which includes this change

@md-hamed
Copy link
Author

@rposborne Glad to hear that! Thanks Russell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@md-hamed @rposborne