New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test suite #271
Comments
@ericmj I created this issue so that I don't forget about it :) Feel free to drop ideas how to improve the test suite even further |
@wojtekmach Do you have any preference for the factory library? https://github.com/thoughtbot/ex_machina and https://github.com/batate/blacksmith both look good, I could introduce it to the tests if that's ok with you. |
I haven't used either of these so not sure. Also, it's really @ericmj's call :) |
@ericmj re factory: since the fresh off-the-press "What's new in ecto 2.0" chapters suggests that in many cases using just ecto 2 is good enough (as opposed to bringing in another dep) I think we should give it a go :) wdyt? |
I talked with @wojtekmach and we decided we can go ahead without a factory library but we should continue moving model creation to the setup callback and we should generate random data for the models so that we still get test concurrency from postgres. |
I have started work on this if you look at the latest commits in master. More work has to be done but I think we can close because improving the test suite will be an ongoing job. |
Per conversation on #265 (comment) there're a few things we could do to clean up the test suite:
test "release docs", %{user: user} do
The text was updated successfully, but these errors were encountered: